Merge pull request 'Fixed crash on non-regular files and connection leaks' (#23) from hotfix/file-browsing-error-for-dev into dev

Reviewed-on: wrenn/wrenn#23

.env.example

@@ -11,7 +11,7 @@ WRENN_CP_LISTEN_ADDR=:9725
 WRENN_HOST_LISTEN_ADDR=:50051
 WRENN_DIR=/var/lib/wrenn
 WRENN_HOST_INTERFACE=eth0
-WRENN_CP_URL=http://localhost:8080
+WRENN_CP_URL=http://localhost:9725
 WRENN_DEFAULT_ROOTFS_SIZE=5Gi
 
 # Lago (billing — external service)

envd/internal/api/download.go

@@ -1,4 +1,5 @@
 // SPDX-License-Identifier: Apache-2.0
+// Modifications by M/S Omukk
 
 package api
 
@@ -106,6 +107,17 @@ func (a *API) GetFiles(w http.ResponseWriter, r *http.Request, params GetFilesPa
 		return
 	}
 
+	// Reject anything that isn't a regular file (devices, pipes, sockets, etc.).
+	// Reading device files like /dev/zero or /dev/urandom produces infinite data
+	// and will exhaust memory on all layers of the stack.
+	if !stat.Mode().IsRegular() {
+		errMsg = fmt.Errorf("path '%s' is not a regular file", resolvedPath)
+		errorCode = http.StatusBadRequest
+		jsonError(w, errorCode, errMsg)
+
+		return
+	}
+
 	// Validate Accept-Encoding header
 	encoding, err := parseAcceptEncoding(r)
 	if err != nil {

frontend/src/lib/api/files.ts

@@ -72,7 +72,11 @@ export async function listDir(capsuleId: string, path: string, depth = 1): Promi
 	}
 }
 
-export async function readFile(capsuleId: string, path: string): Promise<ApiResult<string>> {
+export async function readFile(
+	capsuleId: string,
+	path: string,
+	signal?: AbortSignal,
+): Promise<ApiResult<string>> {
 	try {
 		const headers: Record<string, string> = { 'Content-Type': 'application/json' };
 		if (auth.token) headers['Authorization'] = `Bearer ${auth.token}`;
@@ -81,6 +85,7 @@ export async function readFile(capsuleId: string, path: string): Promise<ApiResu
 			method: 'POST',
 			headers,
 			body: JSON.stringify({ path }),
+			signal,
 		});
 
 		if (!res.ok) {
@@ -95,12 +100,20 @@ export async function readFile(capsuleId: string, path: string): Promise<ApiResu
 		const blob = await res.blob();
 		const text = await blob.text();
 		return { ok: true, data: text };
-	} catch {
+	} catch (e) {
+		if (e instanceof DOMException && e.name === 'AbortError') {
+			return { ok: false, error: 'Request aborted' };
+		}
 		return { ok: false, error: 'Unable to connect to the server' };
 	}
 }
 
-export async function downloadFile(capsuleId: string, path: string, filename: string): Promise<void> {
+export async function downloadFile(
+	capsuleId: string,
+	path: string,
+	filename: string,
+	signal?: AbortSignal,
+): Promise<void> {
 	const headers: Record<string, string> = { 'Content-Type': 'application/json' };
 	if (auth.token) headers['Authorization'] = `Bearer ${auth.token}`;
 
@@ -108,6 +121,7 @@ export async function downloadFile(capsuleId: string, path: string, filename: st
 		method: 'POST',
 		headers,
 		body: JSON.stringify({ path }),
+		signal,
 	});
 
 	if (!res.ok) throw new Error('Download failed');

frontend/src/lib/components/FilesTab.svelte

@@ -1,4 +1,5 @@
 <script lang="ts">
+	import { onDestroy } from 'svelte';
 	import {
 		listDir,
 		readFile,
@@ -37,6 +38,14 @@
 	let dirGeneration = 0;
 	let fileGeneration = 0;
 
+	// AbortController for in-flight file reads — aborted when the user
+	// selects a different file or the component is torn down.
+	let fileAbort: AbortController | null = null;
+
+	onDestroy(() => {
+		fileAbort?.abort();
+	});
+
 	const MAX_PREVIEW_LINES = 5000;
 	const MAX_HIGHLIGHT_LINES = 2000; // Don't tokenize huge files — diminishing returns
 
@@ -83,6 +92,10 @@
 	const canGoUp = $derived(currentPath !== '/' && currentPath.startsWith('/'));
 
 	async function navigateTo(path: string) {
+		// Abort any in-flight file read and invalidate stale generation so the
+		// abort error isn't surfaced in the UI.
+		fileAbort?.abort();
+		++fileGeneration;
 		currentPath = normalizePath(path);
 		pathInput = currentPath;
 		selectedFile = null;
@@ -146,6 +159,9 @@
 			return;
 		}
 
+		// Abort any in-flight file read before starting a new one.
+		fileAbort?.abort();
+
 		selectedFile = entry;
 		fileContent = null;
 		fileError = null;
@@ -159,26 +175,31 @@
 
 		fileLoading = true;
 		const gen = ++fileGeneration;
-		const result = await readFile(capsuleId, entry.path);
-		if (gen !== fileGeneration) return; // stale response — user clicked another file
-		if (result.ok) {
-			if (looksLikeBinary(result.data)) {
-				fileContent = null;
-			} else {
-				fileContent = result.data;
-				// Kick off highlighting in the background — preview shows plain text immediately.
-				// Only tokenize up to MAX_HIGHLIGHT_LINES to avoid freezing on large files.
-				const linesToHighlight = result.data.split('\n').length > MAX_HIGHLIGHT_LINES
-					? result.data.split('\n').slice(0, MAX_HIGHLIGHT_LINES).join('\n')
-					: result.data;
-				tokenize(linesToHighlight, entry.name).then((tokens) => {
-					if (gen === fileGeneration) highlightedTokens = tokens;
-				});
+		const controller = new AbortController();
+		fileAbort = controller;
+		try {
+			const result = await readFile(capsuleId, entry.path, controller.signal);
+			if (gen !== fileGeneration) return; // stale response — user clicked another file
+			if (result.ok) {
+				if (looksLikeBinary(result.data)) {
+					fileContent = null;
+				} else {
+					fileContent = result.data;
+					// Kick off highlighting in the background — preview shows plain text immediately.
+					// Only tokenize up to MAX_HIGHLIGHT_LINES to avoid freezing on large files.
+					const linesToHighlight = result.data.split('\n').length > MAX_HIGHLIGHT_LINES
+						? result.data.split('\n').slice(0, MAX_HIGHLIGHT_LINES).join('\n')
+						: result.data;
+					tokenize(linesToHighlight, entry.name).then((tokens) => {
+						if (gen === fileGeneration) highlightedTokens = tokens;
+					});
+				}
+			} else if (result.error !== 'Request aborted') {
+				fileError = result.error;
 			}
-		} else {
-			fileError = result.error;
+		} finally {
+			if (gen === fileGeneration) fileLoading = false;
 		}
-		fileLoading = false;
 	}
 
 	function looksLikeBinary(text: string): boolean {

internal/hostagent/server.go

@@ -516,6 +516,16 @@ func (s *Server) ReadFileStream(
 	// Stream file content in 64KB chunks.
 	buf := make([]byte, 64*1024)
 	for {
+		// Bail out early if the client disconnected or the context was cancelled.
+		select {
+		case <-ctx.Done():
+			if ctx.Err() == context.DeadlineExceeded {
+				return connect.NewError(connect.CodeDeadlineExceeded, ctx.Err())
+			}
+			return connect.NewError(connect.CodeCanceled, ctx.Err())
+		default:
+		}
+
 		n, err := resp.Body.Read(buf)
 		if n > 0 {
 			chunk := make([]byte, n)